Comments on: Enabling submit button if text entered

By: cakebaker

cakebaker — Thu, 15 Jan 2009 16:16:27 +0000

@all: Thanks for your comments!

@Eelco: Yes, if you don’t want to disable the button in the html you have to use the snippet you provided.

@Xr: Hm, I think this is handled automatically by jQuery. At least if I look at the DOM with FireBug, the “disabled” attribute disappears when the button is enabled by the script (and reappears when the script disables the button).

By: Xr

Xr — Wed, 14 Jan 2009 07:40:51 +0000

Fenrir: for mouse pasting, you could use the onchange event, but it won’t be triggered before a focus change (the submit will not magically be enabled when something is entered).

As for the browser auto-fill, you could probably replace Eelco’s code with

$(function() {
    $('#submit').attr('disabled', !$('#username').val()); 
})

Hoping the browser fills fields before triggering the onload event.

On a sidenote, this does not generate valid XHTML and I’m surprised this works since even the HTML 4.01 specifies that the element will be disabled if the attribute is set (not only if set to a non-null string). In regards to that, the first code was better but I didn’t test any of them.

By: Fenrir

Fenrir — Wed, 14 Jan 2009 03:52:42 +0000

What if username was filled by browser itself or pasted by mouse only?

By: Eelco Wiersma

Eelco Wiersma — Tue, 13 Jan 2009 22:55:49 +0000

Don't forget to add the following, in order to disable the submit button once the document is loaded:


$(function() {
    $('#submit').attr('disabled', 'disabled');
})

Instead of hardcoding the disable tag in your html.